[turbofan] Skip data-flow analysis of code entry field.

[turbofan] Skip data-flow analysis of code entry field.

This makes escape analysis skip analyzing the code entry field within
JSFunction objects. Said field is an untagged pointer field and hence
cannot be tracked by an ObjectState node.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-613494
BUG=chromium:613494
Committed: https://crrev.com/dbd7d5a59f85ff2fd2a06e9377757d2dd6dce45c
Cr-Commit-Position: refs/heads/master@{#36436}

[Michael Starzinger, 2016-05-23 08:23:27]

Description was changed from

==========
[turbofan] Skip data-flow analysis of code entry field.

This makes escape analysis skip analysing the code entry field within
JSFunction objects. Said field is an untagged pointer field and hence
cannot be tracked by an ObjectState node.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-613494
BUG=v8:613494
==========

to

==========
[turbofan] Skip data-flow analysis of code entry field.

This makes escape analysis skip analysing the code entry field within
JSFunction objects. Said field is an untagged pointer field and hence
cannot be tracked by an ObjectState node.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-613494
BUG=chromium:613494
==========

[Michael Starzinger, 2016-05-23 08:25:12]

Description was changed from

==========
[turbofan] Skip data-flow analysis of code entry field.

This makes escape analysis skip analysing the code entry field within
JSFunction objects. Said field is an untagged pointer field and hence
cannot be tracked by an ObjectState node.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-613494
BUG=chromium:613494
==========

to

==========
[turbofan] Skip data-flow analysis of code entry field.

This makes escape analysis skip analyzing the code entry field within
JSFunction objects. Said field is an untagged pointer field and hence
cannot be tracked by an ObjectState node.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-613494
BUG=chromium:613494
==========

[Michael Starzinger, 2016-05-23 08:58:53]

https://codereview.chromium.org/1997353002/diff/20001/src/compiler/escape-ana...
File src/compiler/escape-analysis.cc (right):

https://codereview.chromium.org/1997353002/diff/20001/src/compiler/escape-ana...
src/compiler/escape-analysis.cc:852:
slot_not_analyzed_(graph->NewNode(common->NumberConstant(0.0))),
I went with NumberConstant(0) mainly because it can be materialized without
threading through JSGraph everywhere and without having to access the heap.

[Jarin, 2016-05-23 09:45:54]

lgtm

https://codereview.chromium.org/1997353002/diff/20001/src/compiler/escape-ana...
File src/compiler/escape-analysis.cc (right):

https://codereview.chromium.org/1997353002/diff/20001/src/compiler/escape-ana...
src/compiler/escape-analysis.cc:852:
slot_not_analyzed_(graph->NewNode(common->NumberConstant(0.0))),
On 2016/05/23 08:58:53, Michael Starzinger wrote:
> I went with NumberConstant(0) mainly because it can be materialized without
> threading through JSGraph everywhere and without having to access the heap.

Nit: I am wondering whether it would make sense to use some less common Smi here
so that it is clearer where it came from if it leaks.

[Michael Starzinger, 2016-05-23 09:57:13]

Thanks! Addressed comments. Landing.

https://codereview.chromium.org/1997353002/diff/20001/src/compiler/escape-ana...
File src/compiler/escape-analysis.cc (right):

https://codereview.chromium.org/1997353002/diff/20001/src/compiler/escape-ana...
src/compiler/escape-analysis.cc:852:
slot_not_analyzed_(graph->NewNode(common->NumberConstant(0.0))),
On 2016/05/23 09:45:54, Jarin wrote:
> On 2016/05/23 08:58:53, Michael Starzinger wrote:
> > I went with NumberConstant(0) mainly because it can be materialized without
> > threading through JSGraph everywhere and without having to access the heap.
> 
> Nit: I am wondering whether it would make sense to use some less common Smi
here
> so that it is clearer where it came from if it leaks.

Done.

[Michael Starzinger, 2016-05-23 10:36:53]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-05-23 10:36:54]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/1997353002/#ps40001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-05-23 10:37:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1997353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1997353002/40001

[commit-bot: I haz the power, 2016-05-23 10:39:31]

Description was changed from

==========
[turbofan] Skip data-flow analysis of code entry field.

This makes escape analysis skip analyzing the code entry field within
JSFunction objects. Said field is an untagged pointer field and hence
cannot be tracked by an ObjectState node.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-613494
BUG=chromium:613494
==========

to

==========
[turbofan] Skip data-flow analysis of code entry field.

This makes escape analysis skip analyzing the code entry field within
JSFunction objects. Said field is an untagged pointer field and hence
cannot be tracked by an ObjectState node.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-613494
BUG=chromium:613494
==========

[commit-bot: I haz the power, 2016-05-23 10:39:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-23 10:40:40]

Description was changed from

==========
[turbofan] Skip data-flow analysis of code entry field.

This makes escape analysis skip analyzing the code entry field within
JSFunction objects. Said field is an untagged pointer field and hence
cannot be tracked by an ObjectState node.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-613494
BUG=chromium:613494
==========

to

==========
[turbofan] Skip data-flow analysis of code entry field.

This makes escape analysis skip analyzing the code entry field within
JSFunction objects. Said field is an untagged pointer field and hence
cannot be tracked by an ObjectState node.

R=jarin@chromium.org
TEST=mjsunit/regress/regress-crbug-613494
BUG=chromium:613494

Committed: https://crrev.com/dbd7d5a59f85ff2fd2a06e9377757d2dd6dce45c
Cr-Commit-Position: refs/heads/master@{#36436}
==========

[commit-bot: I haz the power, 2016-05-23 10:40:41]

Patchset 3 (id:??) landed as
https://crrev.com/dbd7d5a59f85ff2fd2a06e9377757d2dd6dce45c
Cr-Commit-Position: refs/heads/master@{#36436}