Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 199733016: implement readPixels and writePixels natively, w/o using the (deprecated) (Closed)

Created:
6 years, 9 months ago by reed1
Modified:
6 years, 9 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

implement readPixels and writePixels natively, w/o using the (deprecated) SkCanvas::Config8888 enum. Revert "Revert "hide Config8888 entirely". Broke a bunch of builds." This reverts commit 763277ba157fef0f651004bb98a189e9f1ac730b. Needs chrome to remove the READPIXELS guard from skia's .gyp Committed: https://code.google.com/p/skia/source/detail?r=13931

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+421 lines, -610 lines) Patch
M include/core/SkCanvas.h View 1 3 chunks +8 lines, -0 lines 0 comments Download
M include/core/SkColorPriv.h View 4 chunks +138 lines, -2 lines 0 comments Download
M include/core/SkDevice.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +14 lines, -34 lines 0 comments Download
M src/core/SkConfig8888.h View 1 chunk +17 lines, -65 lines 0 comments Download
M src/core/SkConfig8888.cpp View 1 chunk +85 lines, -248 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 4 chunks +39 lines, -72 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +16 lines, -5 lines 0 comments Download
M tests/DeferredCanvasTest.cpp View 7 chunks +6 lines, -21 lines 0 comments Download
M tests/WritePixelsTest.cpp View 1 9 chunks +96 lines, -117 lines 0 comments Download
M tools/sk_tool_utils.h View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/sk_tool_utils.cpp View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
reed1
same as before when it landed, but now chrome is ready to receive this.
6 years, 9 months ago (2014-03-25 11:59:57 UTC) #1
reed1
Committed patchset #2 manually as r13931.
6 years, 9 months ago (2014-03-25 12:00:47 UTC) #2
mtklein
On 2014/03/25 12:00:47, reed1 wrote: > Committed patchset #2 manually as r13931. Looks like the ...
6 years, 9 months ago (2014-03-25 13:37:58 UTC) #3
mtklein
6 years, 9 months ago (2014-03-25 13:38:26 UTC) #4
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/209233004/ by mtklein@google.com.

The reason for reverting is: Android bots segfaulting in tests..

Powered by Google App Engine
This is Rietveld 408576698