Issue 199733012: Split of rolling Chromium from push-to-trunk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199733012: Split of rolling Chromium from push-to-trunk. (Closed)

Created:
6 years, 9 months ago by Michael Achenbach

Modified:
6 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev, Jarin

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Split of rolling Chromium from push-to-trunk. This moves rolling Chromium into a new script with its own tests. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20159

Patch Set 2 : Sync auto-roll. #

Patch Set 3 : Fix location for retrieving the push title. #

Total comments: 2

Patch Set 5 : Rebase. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+242 lines, -129 lines)			Patch
M	tools/push-to-trunk/auto_roll.py	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download
A	tools/push-to-trunk/chromium_roll.py	View	1 2 3	1 chunk	+170 lines, -0 lines	0 comments	Download
M	tools/push-to-trunk/push_to_trunk.py	View	1 2 3 4	6 chunks	+5 lines, -104 lines	0 comments	Download
M	tools/push-to-trunk/test_scripts.py	View	1 2 3 4	6 chunks	+65 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

lgtm https://codereview.chromium.org/199733012/diff/60001/tools/push-to-trunk/chromium_roll.py File tools/push-to-trunk/chromium_roll.py (right): https://codereview.chromium.org/199733012/diff/60001/tools/push-to-trunk/chromium_roll.py#newcode3 tools/push-to-trunk/chromium_roll.py:3: # Redistribution and use in source and binary ...

6 years, 9 months ago (2014-03-20 15:16:54 UTC) #2

Michael Achenbach

6 years, 9 months ago (2014-03-21 12:15:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as r20159 (presubmit successful).