Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 199733011: DevTools: [JsDocValidator] Avoid false-positive function receiver-related errors (Closed)

Created:
6 years, 9 months ago by apavlov
Modified:
6 years, 9 months ago
Reviewers:
vsevik, aandrey, sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: [JsDocValidator] Avoid false-positive function receiver-related errors The RequiredThisAnnotationChecker has been merged into FunctionReceiverChecker, so it can now make use of the knowledge whether a nested function references |this| or not. As such, the receiver checks now rely on the fact of the |this| usage rather than the presence of the @this annotation. R=aandrey@chromium.org, aandrey, sergeyv, vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169643

Patch Set 1 #

Messages

Total messages: 3 (0 generated)
apavlov
6 years, 9 months ago (2014-03-20 10:52:08 UTC) #1
aandrey
lgtm
6 years, 9 months ago (2014-03-20 10:55:30 UTC) #2
apavlov
6 years, 9 months ago (2014-03-20 11:57:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r169643 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698