Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 199733008: Revert of HTML Imports: Send credentials for same origin requests (Closed)

Created:
6 years, 9 months ago by tkent
Modified:
6 years, 9 months ago
CC:
blink-reviews, adamk+blink_chromium.org, gavinp+prerender_chromium.org, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, gavinp+loader_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

Revert of HTML Imports: Send credentials for same origin requests (https://codereview.chromium.org/196043002/) Reason for revert: The following tests crash on all debug bots. - fast/shapes/shape-inside/shape-inside-image-set.html - fast/shapes/shape-outside-floats/shape-outside-image-set.html Original issue's description: > HTML Imports: Send credentials for same origin requests > > This captures following spec chagne: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24905 > The essential part of the change is in HTMLImportsController.cpp. > Anything else is to make it work with redirect. > > The problem here is that allowCredentials flag is held both > by ResourceLoaderOptions and ResourceRequest and these two > can go out-of-sync. This change tries to make them in sync. > > Such a state duplication should be resolved eventually, but > that is another story. > > BUG=348671 > TEST=import-cors-credentials.html > R=dglazkov@chromium.org, japhet@chromium.org, abarth > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169496 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169578 TBR=abarth@chromium.org,dglazkov@chromium.org,japhet@chromium.org,morrita@chromium.org NOTREECHECKS=true NOTRY=true BUG=348671 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169618

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -97 lines) Patch
D LayoutTests/http/tests/htmlimports/import-cors-credentials.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/http/tests/htmlimports/import-cors-credentials-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/http/tests/htmlimports/resources/cookie-match.cgi View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/http/tests/htmlimports/resources/having-cookie-match-8080.html View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/http/tests/htmlimports/resources/having-cookie-match-same.cgi View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/css/CSSImageSetValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/CrossOriginAccessControl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/FetchRequest.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/FetchRequest.cpp View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/fetch/Resource.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/Resource.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/fetch/ResourceLoader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/fetch/ResourceLoader.cpp View 7 chunks +6 lines, -11 lines 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/html/imports/HTMLImportsController.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tkent
Created Revert of HTML Imports: Send credentials for same origin requests
6 years, 9 months ago (2014-03-20 05:27:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/199733008/1
6 years, 9 months ago (2014-03-20 05:27:31 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 05:28:04 UTC) #3
Message was sent while issue was closed.
Change committed as 169618

Powered by Google App Engine
This is Rietveld 408576698