Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 199733007: Remove start & stop logic from timeline_metric. (Closed)

Created:
6 years, 9 months ago by nednguyen
Modified:
6 years, 9 months ago
Reviewers:
nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move start & stop logic from timeline_metric to measurement/. This is the first step in moving timeline and thread_time to timeline_based_metric API. BUG=345922 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259710

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -115 lines) Patch
M tools/perf/measurements/loading_trace.py View 3 chunks +9 lines, -4 lines 0 comments Download
M tools/perf/measurements/thread_times.py View 2 chunks +21 lines, -10 lines 0 comments Download
M tools/perf/measurements/timeline_based_measurement.py View 2 chunks +2 lines, -2 lines 0 comments Download
A tools/perf/measurements/timeline_controller.py View 1 chunk +70 lines, -0 lines 0 comments Download
M tools/perf/metrics/timeline.py View 4 chunks +11 lines, -80 lines 0 comments Download
M tools/perf/metrics/timeline_unittest.py View 7 chunks +15 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nednguyen
6 years, 9 months ago (2014-03-20 04:47:21 UTC) #1
nduca
lgtm
6 years, 9 months ago (2014-03-26 17:36:21 UTC) #2
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 9 months ago (2014-03-26 17:37:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/199733007/1
6 years, 9 months ago (2014-03-26 17:39:00 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 18:32:08 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 9 months ago (2014-03-26 18:32:09 UTC) #6
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 9 months ago (2014-03-26 18:48:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/199733007/1
6 years, 9 months ago (2014-03-26 18:51:44 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 22:05:08 UTC) #9
Message was sent while issue was closed.
Change committed as 259710

Powered by Google App Engine
This is Rietveld 408576698