Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuObserver.java

Issue 199733002: Cleanup AppMenu code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move lint suppression to AppMenuDragHelper Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuObserver.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuObserver.java
index db801f3e177bf754b14428fc68057953c00e08a6..c133bc38c8989435bc0bd78330058520c59b25be 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuObserver.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuObserver.java
@@ -4,30 +4,13 @@
package org.chromium.chrome.browser.appmenu;
-import com.google.common.annotations.VisibleForTesting;
-
/**
* Allows monitoring of application menu actions.
*/
public interface AppMenuObserver {
/**
* Informs when the App Menu visibility changes.
- * @param newState Whether the menu is now visible.
- * @param focusedPosition The position that is currently in focus.
- */
- public void onMenuVisibilityChanged(boolean newState, int focusedPosition);
-
- /**
- * Notifies that the keyboard focus has changed within the App Menu.
- * @param focusedPosition The position that is currently in focus.
- */
- @VisibleForTesting
- public void onKeyboardFocusChanged(int focusedPosition);
-
- /**
- * Notifies that the keyboard has activated an item in the App Menu.
- * @param focusedPosition The position of the item that was activated.
+ * @param isVisible Whether the menu is now visible.
*/
- @VisibleForTesting
- public void onKeyboardActivatedItem(int focusedPosition);
+ public void onMenuVisibilityChanged(boolean isVisible);
}

Powered by Google App Engine
This is Rietveld 408576698