Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1997263002: Convert audio-constructor* tests to testharness.js (Closed)

Created:
4 years, 7 months ago by Srirama
Modified:
4 years, 7 months ago
Reviewers:
fs
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert audio-constructor* tests to testharness.js Cleaning up audio-constructor* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/97f3e582530ef802bc9c6575f320cab989983e86 Cr-Commit-Position: refs/heads/master@{#395319}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -103 lines) Patch
M third_party/WebKit/LayoutTests/media/audio-constructor.html View 1 chunk +16 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/audio-constructor-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/audio-constructor-preload.html View 1 chunk +22 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/audio-constructor-preload-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/audio-constructor-src.html View 1 chunk +13 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/audio-constructor-src-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Srirama
PTAL
4 years, 7 months ago (2016-05-22 17:38:17 UTC) #7
fs
lgtm
4 years, 7 months ago (2016-05-23 08:33:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997263002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997263002/60001
4 years, 7 months ago (2016-05-23 09:41:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/233675)
4 years, 7 months ago (2016-05-23 12:04:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997263002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997263002/60001
4 years, 7 months ago (2016-05-23 13:23:36 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 7 months ago (2016-05-23 14:32:20 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 14:34:13 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97f3e582530ef802bc9c6575f320cab989983e86
Cr-Commit-Position: refs/heads/master@{#395319}

Powered by Google App Engine
This is Rietveld 408576698