webRequest: Set frameId on beacon/ping requests.

third_party/WebKit/Source/core/loader/PingLoader.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 119 matching lines @@
     ASSERT_UNUSED(loader, loader);
 }
 
 PingLoader::PingLoader(LocalFrame* frame, ResourceRequest& request, const FetchInitiatorInfo& initiatorInfo, StoredCredentials credentialsAllowed)
     : LocalFrameLifecycleObserver(frame)
     , m_timeout(this, &PingLoader::timeout)
     , m_url(request.url())
     , m_identifier(createUniqueIdentifier())
     , m_keepAlive(this)
 {
+    ResourceResponse redirectResponse;
     frame->loader().client()->didDispatchPingLoader(request.url());
+    frame->loader().client()->dispatchWillSendRequest(frame->loader().documentLoader(), m_identifier, request, redirectResponse);

[Nate Chapin, 2016/05/23 21:28:04]

Could we call frame->document()->fetcher()->context().dispatchWillSendRequest()
instead of doing this and the 2 lines below? This code appears to be
unnecessarily (and until your change, incorrectly!) duplicated.

[robwu, 2016/05/23 22:28:31]

Done.

 
     TRACE_EVENT_INSTANT1("devtools.timeline", "ResourceSendRequest", TRACE_EVENT_SCOPE_THREAD, "data", InspectorSendRequestEvent::data(m_identifier, frame, request));
-    InspectorInstrumentation::willSendRequest(frame, m_identifier, frame->loader().documentLoader(), request, ResourceResponse(), initiatorInfo);
+    InspectorInstrumentation::willSendRequest(frame, m_identifier, frame->loader().documentLoader(), request, redirectResponse, initiatorInfo);
 
     m_loader = adoptPtr(Platform::current()->createURLLoader());
     ASSERT(m_loader);
     WrappedResourceRequest wrappedRequest(request);
     wrappedRequest.setAllowStoredCredentials(credentialsAllowed == AllowStoredCredentials);
     m_loader->loadAsynchronously(wrappedRequest, this);
 
     // If the server never responds, FrameLoader won't be able to cancel this load and
     // we'll sit here waiting forever. Set a very generous timeout, just in case.
     m_timeout.startOneShot(60000, BLINK_FROM_HERE);
@@ skipping 66 matching lines @@
     InspectorInstrumentation::didFailLoading(frame, m_identifier, ResourceError::cancelledError(m_url));
     frame->console().didFailLoading(m_identifier, ResourceError::cancelledError(m_url));
 }
 
 DEFINE_TRACE(PingLoader)
 {
     LocalFrameLifecycleObserver::trace(visitor);
 }
 
 } // namespace blink