Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1997223002: [stubs] Enforce correct index representation on 64-bit. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Enforce correct index representation on 64-bit. Address computation on 64-bit platforms must be done in Word64, mixing Word32 here is unsound. TBR=danno@chromium.org Committed: https://crrev.com/392c1d8e1150a3a02d0f859eef4bb19c9ffa0698 Cr-Commit-Position: refs/heads/master@{#36428}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/code-stub-assembler.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997223002/1
4 years, 7 months ago (2016-05-21 19:15:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-21 19:46:35 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/392c1d8e1150a3a02d0f859eef4bb19c9ffa0698 Cr-Commit-Position: refs/heads/master@{#36428}
4 years, 7 months ago (2016-05-21 19:49:08 UTC) #5
danno
4 years, 7 months ago (2016-05-23 08:19:53 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698