Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 19972003: [Telemetry] Default to most recent local build if --browser is omitted. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move SelectDefaultBrowser to platform finders Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_runner.py
diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py
index a3f1b8552c27221b0c819f5d40760e09ed15cf20..1383f93be4bec0c687e1128f10b84174c336b54b 100644
--- a/tools/telemetry/telemetry/page/page_runner.py
+++ b/tools/telemetry/telemetry/page/page_runner.py
@@ -153,10 +153,16 @@ def Run(test, page_set, expectations, options):
# Create a possible_browser with the given options.
test.CustomizeBrowserOptions(options)
- possible_browser = browser_finder.FindBrowser(options)
+ try:
+ possible_browser = browser_finder.FindBrowser(options)
+ except browser_finder.BrowserTypeRequiredException, e:
+ sys.stderr.write(str(e) + '\n')
+ sys.exit(1)
if not possible_browser:
- raise Exception('No browser found.\n'
- 'Use --browser=list to figure out which are available.')
+ sys.stderr.write(
+ 'No browser found. Available browsers:\n' +
+ '\n'.join(browser_finder.GetAllAvailableBrowserTypes(options)) + '\n')
+ sys.exit(1)
# Reorder page set based on options.
pages = _ShuffleAndFilterPageSet(page_set, options)

Powered by Google App Engine
This is Rietveld 408576698