Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1997193002:
Update selection region style (Closed)
|
Created:
4 years, 7 months ago by oshima Modified:
4 years, 6 months ago Reviewers:
Qiang(Joe) Xu CC:
chromium-reviews, kalyank, sadrul Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate selection region style
* use simple gray region
* use gray for unselected regions instead.
* use darker gray for unselected region
* Instead of using platform cursor, draw pseudo cursor when selecting region
BUG=608269
Committed: https://crrev.com/ef6f5af980b06e664d0cd9dc7cb578d6862b6c36
Cr-Commit-Position: refs/heads/master@{#397498}
Patch Set 1 #Patch Set 2 : #
Messages
Total messages: 35 (20 generated)
Description was changed from ========== Use simple gray for selected region BUG=608269 ========== to ========== Update selection region style * use simple gray region * use gray for unselected regions instead. * use darker gray for unselected region BUG=608269 ==========
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997193002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
oshima@chromium.org changed reviewers: + warx@chromium.org
On 2016/05/21 22:05:13, oshima wrote: lgtm
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997193002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #2 (id:20001) has been deleted
Patchset #2 (id:40001) has been deleted
Patchset #2 (id:60001) has been deleted
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997193002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997193002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #3 (id:100001) has been deleted
Patchset #2 (id:80001) has been deleted
Patchset #2 (id:120001) has been deleted
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997193002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997193002/140001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Update selection region style * use simple gray region * use gray for unselected regions instead. * use darker gray for unselected region BUG=608269 ========== to ========== Update selection region style * use simple gray region * use gray for unselected regions instead. * use darker gray for unselected region * Instead of using platform cursor, draw pseudo cursor when selecting region BUG=608269 ==========
hi, I discussed wit kuscher and we decided to draw pseudo cursor instead of platform cursor so that cursor edge matches the region. ptal.
On 2016/06/01 16:18:22, oshima wrote: > hi, I discussed wit kuscher and we decided to draw pseudo cursor instead of > platform cursor so that cursor edge matches the region. ptal. lgtm
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997193002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997193002/140001
Message was sent while issue was closed.
Description was changed from ========== Update selection region style * use simple gray region * use gray for unselected regions instead. * use darker gray for unselected region * Instead of using platform cursor, draw pseudo cursor when selecting region BUG=608269 ========== to ========== Update selection region style * use simple gray region * use gray for unselected regions instead. * use darker gray for unselected region * Instead of using platform cursor, draw pseudo cursor when selecting region BUG=608269 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:140001)
Message was sent while issue was closed.
Description was changed from ========== Update selection region style * use simple gray region * use gray for unselected regions instead. * use darker gray for unselected region * Instead of using platform cursor, draw pseudo cursor when selecting region BUG=608269 ========== to ========== Update selection region style * use simple gray region * use gray for unselected regions instead. * use darker gray for unselected region * Instead of using platform cursor, draw pseudo cursor when selecting region BUG=608269 Committed: https://crrev.com/ef6f5af980b06e664d0cd9dc7cb578d6862b6c36 Cr-Commit-Position: refs/heads/master@{#397498} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ef6f5af980b06e664d0cd9dc7cb578d6862b6c36 Cr-Commit-Position: refs/heads/master@{#397498} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
