Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: base/trace_event/trace_event.h

Issue 1997153002: libchrome: Several upstreamable fixes from libchrome Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: Addressed feedback Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/trace_event.h
diff --git a/base/trace_event/trace_event.h b/base/trace_event/trace_event.h
index faaccac8eaf34b40ff91b81e633df44246266a6a..a07589826978826842f6a255017005d49a2d7186 100644
--- a/base/trace_event/trace_event.h
+++ b/base/trace_event/trace_event.h
@@ -474,9 +474,8 @@ class TraceID {
TraceID(ForceMangle raw_id, unsigned int* flags) : raw_id_(raw_id.raw_id()) {
*flags |= TRACE_EVENT_FLAG_MANGLE_ID;
}
- TraceID(DontMangle maybe_scoped_id, unsigned int* flags)
- : scope_(maybe_scoped_id.scope()), raw_id_(maybe_scoped_id.raw_id()) {
- }
+ TraceID(DontMangle maybe_scoped_id, unsigned int* /*flags*/)
+ : scope_(maybe_scoped_id.scope()), raw_id_(maybe_scoped_id.raw_id()) {}
TraceID(unsigned long long raw_id, unsigned int* flags) : raw_id_(raw_id) {
(void)flags;
}
@@ -502,7 +501,7 @@ class TraceID {
: raw_id_(static_cast<unsigned long long>(raw_id)) { (void)flags; }
TraceID(signed char raw_id, unsigned int* flags)
: raw_id_(static_cast<unsigned long long>(raw_id)) { (void)flags; }
- TraceID(WithScope scoped_id, unsigned int* flags)
+ TraceID(WithScope scoped_id, unsigned int* /*flags*/)
: scope_(scoped_id.scope()), raw_id_(scoped_id.raw_id()) {}
unsigned long long raw_id() const { return raw_id_; }

Powered by Google App Engine
This is Rietveld 408576698