base/strings/utf_string_conversion_utils.cc - Issue 1997153002: libchrome: Several upstreamable fixes from libchrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/strings/utf_string_conversion_utils.cc

Issue 1997153002: libchrome: Several upstreamable fixes from libchrome Base URL: https://chromium.googlesource.com/a/chromium/src.git@master

Patch Set: Addressed feedback Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/strings/utf_string_conversion_utils.cc

diff --git a/base/strings/utf_string_conversion_utils.cc b/base/strings/utf_string_conversion_utils.cc

index 3101a60288837ab193584fb85fd8393cabea8af6..22058a5afff4e93fbdd8fd579b6f03bbd3a51e3c 100644

--- a/base/strings/utf_string_conversion_utils.cc

+++ b/base/strings/utf_string_conversion_utils.cc

@@ -55,7 +55,7 @@ bool ReadUnicodeCharacter(const char16* src,

#if defined(WCHAR_T_IS_UTF32)

bool ReadUnicodeCharacter(const wchar_t* src,

- int32_t src_len,

+ int32_t /*src_len*/,

int32_t* char_index,

uint32_t* code_point) {

// Conversion is easy since the source is 32-bit.