base/numerics/safe_math_impl.h - Issue 1997153002: libchrome: Several upstreamable fixes from libchrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/numerics/safe_math_impl.h

Issue 1997153002: libchrome: Several upstreamable fixes from libchrome Base URL: https://chromium.googlesource.com/a/chromium/src.git@master

Patch Set: Addressed feedback Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/numerics/safe_math_impl.h

diff --git a/base/numerics/safe_math_impl.h b/base/numerics/safe_math_impl.h

index 77a9b0ba3c8b0395da0a630efc137a640fc73856..f214f3fec2fa43f9ee4444d165a566fd7bdeaa2f 100644

--- a/base/numerics/safe_math_impl.h

+++ b/base/numerics/safe_math_impl.h

@@ -445,7 +445,7 @@ class CheckedNumericState<T, NUMERIC_FLOATING> {

template <typename Src>

CheckedNumericState(

Src value,

- RangeConstraint validity,

+ RangeConstraint /*validity*/,

typename std::enable_if<std::numeric_limits<Src>::is_integer, int>::type =

0) {

switch (DstRangeRelationToSrcRange<T>(value)) {