Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/metrics/persistent_histogram_allocator.cc

Issue 1997153002: libchrome: Several upstreamable fixes from libchrome Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: Addressed feedback Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/metrics/histogram.cc ('K') | « base/metrics/histogram_samples.cc ('k') | base/metrics/sample_vector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/persistent_histogram_allocator.cc
diff --git a/base/metrics/persistent_histogram_allocator.cc b/base/metrics/persistent_histogram_allocator.cc
index 20f64336016ae7acf269c3faa25ba3e8fc585425..9608fba725ae3aaf789905820dab00c83df7d4fc 100644
--- a/base/metrics/persistent_histogram_allocator.cc
+++ b/base/metrics/persistent_histogram_allocator.cc
@@ -624,8 +624,8 @@ void GlobalHistogramAllocator::CreateWithLocalMemory(
void GlobalHistogramAllocator::CreateWithSharedMemory(
std::unique_ptr<SharedMemory> memory,
size_t size,
- uint64_t id,
- StringPiece name) {
+ uint64_t /*id*/,
+ StringPiece /*name*/) {
if ((!memory->memory() && !memory->Map(size)) ||
!SharedPersistentMemoryAllocator::IsSharedMemoryAcceptable(*memory)) {
NOTREACHED();
« base/metrics/histogram.cc ('K') | « base/metrics/histogram_samples.cc ('k') | base/metrics/sample_vector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698