Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5682)

Unified Diff: base/message_loop/message_pump_libevent.cc

Issue 1997153002: libchrome: Several upstreamable fixes from libchrome Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: Addressed feedback Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/message_loop/message_pump_libevent.cc
diff --git a/base/message_loop/message_pump_libevent.cc b/base/message_loop/message_pump_libevent.cc
index fef01da9a657820672e56fd2daa6c3d6b17806c9..ccfb3761f30cf9ae60cef11b86b68f266a40b9ce 100644
--- a/base/message_loop/message_pump_libevent.cc
+++ b/base/message_loop/message_pump_libevent.cc
@@ -87,7 +87,8 @@ event *MessagePumpLibevent::FileDescriptorWatcher::ReleaseEvent() {
}
void MessagePumpLibevent::FileDescriptorWatcher::OnFileCanReadWithoutBlocking(
- int fd, MessagePumpLibevent* pump) {
+ int fd,
+ MessagePumpLibevent*) {
// Since OnFileCanWriteWithoutBlocking() gets called first, it can stop
// watching the file descriptor.
if (!watcher_)
@@ -96,7 +97,8 @@ void MessagePumpLibevent::FileDescriptorWatcher::OnFileCanReadWithoutBlocking(
}
void MessagePumpLibevent::FileDescriptorWatcher::OnFileCanWriteWithoutBlocking(
- int fd, MessagePumpLibevent* pump) {
+ int fd,
+ MessagePumpLibevent*) {
DCHECK(watcher_);
watcher_->OnFileCanWriteWithoutBlocking(fd);
}
@@ -195,8 +197,7 @@ bool MessagePumpLibevent::WatchFileDescriptor(int fd,
}
// Tell libevent to break out of inner loop.
-static void timer_callback(int fd, short events, void *context)
-{
+static void timer_callback(int /*fd*/, short /*events*/, void* context) {
event_base_loopbreak((struct event_base *)context);
}
@@ -347,7 +348,7 @@ void MessagePumpLibevent::OnLibeventNotification(int fd,
// Called if a byte is received on the wakeup pipe.
// static
-void MessagePumpLibevent::OnWakeup(int socket, short flags, void* context) {
+void MessagePumpLibevent::OnWakeup(int socket, short /*flags*/, void* context) {
MessagePumpLibevent* that = static_cast<MessagePumpLibevent*>(context);
DCHECK(that->wakeup_pipe_out_ == socket);

Powered by Google App Engine
This is Rietveld 408576698