Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: base/memory/shared_memory_android.cc

Issue 1997153002: libchrome: Several upstreamable fixes from libchrome Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: Addressed feedback Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/memory/shared_memory_android.cc
diff --git a/base/memory/shared_memory_android.cc b/base/memory/shared_memory_android.cc
index 6f1d9cb874c664891a1cfaa71920b803ef4c8eaa..f42c605e1fc11181e274c1ee4e4cb3bd78b30703 100644
--- a/base/memory/shared_memory_android.cc
+++ b/base/memory/shared_memory_android.cc
@@ -52,13 +52,13 @@ bool SharedMemory::Create(const SharedMemoryCreateOptions& options) {
return true;
}
-bool SharedMemory::Delete(const std::string& name) {
+bool SharedMemory::Delete(const std::string&) {
// Like on Windows, this is intentionally returning true as ashmem will
// automatically releases the resource when all FDs on it are closed.
return true;
}
-bool SharedMemory::Open(const std::string& name, bool read_only) {
+bool SharedMemory::Open(const std::string&, bool /*read_only*/) {
// ashmem doesn't support name mapping
NOTIMPLEMENTED();
return false;

Powered by Google App Engine
This is Rietveld 408576698