base/lazy_instance.h - Issue 1997153002: libchrome: Several upstreamable fixes from libchrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/lazy_instance.h

Issue 1997153002: libchrome: Several upstreamable fixes from libchrome Base URL: https://chromium.googlesource.com/a/chromium/src.git@master

Patch Set: Addressed feedback Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/lazy_instance.h

diff --git a/base/lazy_instance.h b/base/lazy_instance.h

index fd0321017df8f8ba6643f1326db2db581fd05ed5..72befe45d5e1ca9b84c8bb8d19e7717e766101af 100644

--- a/base/lazy_instance.h

+++ b/base/lazy_instance.h

@@ -97,8 +97,7 @@ struct LeakyLazyInstanceTraits {

ANNOTATE_SCOPED_MEMORY_LEAK;

return DefaultLazyInstanceTraits<Type>::New(instance);

}

- static void Delete(Type* instance) {

- }

+ static void Delete(Type*) {}

};

// Our AtomicWord doubles as a spinlock, where a value of