base/numerics/safe_conversions_impl.h - Issue 1997153002: libchrome: Several upstreamable fixes from libchrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/numerics/safe_conversions_impl.h

Issue 1997153002: libchrome: Several upstreamable fixes from libchrome Base URL: https://chromium.googlesource.com/a/chromium/src.git@master

Patch Set: Also fix unit tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/numerics/safe_conversions_impl.h

diff --git a/base/numerics/safe_conversions_impl.h b/base/numerics/safe_conversions_impl.h

index 9279ecc3fb1e279909da2fa5bc3a23395bdaab7a..3ab854563eb6c7deec97f9d708270f8c51e37a53 100644

--- a/base/numerics/safe_conversions_impl.h

+++ b/base/numerics/safe_conversions_impl.h

@@ -188,7 +188,9 @@ struct DstRangeRelationToSrcRangeImpl<Dst,

DstSign,

SrcSign,

NUMERIC_RANGE_CONTAINED> {

- static constexpr RangeConstraint Check(Src value) { return RANGE_VALID; }

+ static constexpr RangeConstraint Check(Src /* value */) {

+ return RANGE_VALID;

+ }

};

// Signed to signed narrowing: Both the upper and lower boundaries may be