Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: base/metrics/sparse_histogram.cc

Issue 1997153002: libchrome: Several upstreamable fixes from libchrome Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: Also fix unit tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/metrics/sparse_histogram.cc
diff --git a/base/metrics/sparse_histogram.cc b/base/metrics/sparse_histogram.cc
index a2dbb61b218b9b42b90543547c344fb42d26b5cc..121d5f02edda28854aa3fe58af27a74612ed8e40 100644
--- a/base/metrics/sparse_histogram.cc
+++ b/base/metrics/sparse_histogram.cc
@@ -93,9 +93,9 @@ HistogramType SparseHistogram::GetHistogramType() const {
}
bool SparseHistogram::HasConstructionArguments(
- Sample expected_minimum,
- Sample expected_maximum,
- uint32_t expected_bucket_count) const {
+ Sample /* expected_minimum */,
+ Sample /* expected_maximum */,
+ uint32_t /* expected_bucket_count */) const {
// SparseHistogram never has min/max/bucket_count limit.
return false;
}
@@ -214,13 +214,13 @@ HistogramBase* SparseHistogram::DeserializeInfoImpl(PickleIterator* iter) {
return SparseHistogram::FactoryGet(histogram_name, flags);
}
-void SparseHistogram::GetParameters(DictionaryValue* params) const {
+void SparseHistogram::GetParameters(DictionaryValue* /* params */) const {
// TODO(kaiwang): Implement. (See HistogramBase::WriteJSON.)
}
-void SparseHistogram::GetCountAndBucketData(Count* count,
- int64_t* sum,
- ListValue* buckets) const {
+void SparseHistogram::GetCountAndBucketData(Count* /* count */,
+ int64_t* /* sum */,
+ ListValue* /* buckets */) const {
// TODO(kaiwang): Implement. (See HistogramBase::WriteJSON.)
}

Powered by Google App Engine
This is Rietveld 408576698