base/metrics/histogram_samples.cc - Issue 1997153002: libchrome: Several upstreamable fixes from libchrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_samples.cc

Issue 1997153002: libchrome: Several upstreamable fixes from libchrome Base URL: https://chromium.googlesource.com/a/chromium/src.git@master

Patch Set: Also fix unit tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/metrics/histogram_samples.cc

diff --git a/base/metrics/histogram_samples.cc b/base/metrics/histogram_samples.cc

index 3475cd59f71df439ebd7cd124d4614ccd588b98a..bfa54ba4a30de52e0499fe3e441aced726ccf56b 100644

--- a/base/metrics/histogram_samples.cc

+++ b/base/metrics/histogram_samples.cc

@@ -147,7 +147,7 @@ void HistogramSamples::IncreaseRedundantCount(HistogramBase::Count diff) {

SampleCountIterator::~SampleCountIterator() {}

-bool SampleCountIterator::GetBucketIndex(size_t* index) const {

+bool SampleCountIterator::GetBucketIndex(size_t* /* index */) const {

DCHECK(!Done());

return false;

}