libchrome: Several upstreamable fixes from libchrome

crypto/secure_hash.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "crypto/secure_hash.h"
 
 #include <openssl/mem.h>
 #include <openssl/sha.h>
 #include <stddef.h>
 
 #include "base/logging.h"
 #include "base/pickle.h"
 #include "crypto/openssl_util.h"
 
 namespace crypto {
 
 namespace {
 
 class SecureHashSHA256 : public SecureHash {
  public:
   SecureHashSHA256() {
     SHA256_Init(&ctx_);
   }
 
-  SecureHashSHA256(const SecureHashSHA256& other) {
+  SecureHashSHA256(const SecureHashSHA256& other) : SecureHash() {

[Ryan Sleevi, 2016/05/21 10:33:33]

Why. The existing code is doing the right thing.

[Luis Héctor Chávez, 2016/05/24 15:27:53]

Nevermind, I realized the branch I was building this on used an older version of
gcc. Doesn't reproduce with other versions of gcc or clang, so removed this.

     memcpy(&ctx_, &other.ctx_, sizeof(ctx_));
   }
 
   ~SecureHashSHA256() override {
     OPENSSL_cleanse(&ctx_, sizeof(ctx_));
   }
 
   void Update(const void* input, size_t len) override {
     SHA256_Update(&ctx_, static_cast<const unsigned char*>(input), len);
   }
@@ skipping 20 matching lines @@
   switch (algorithm) {
     case SHA256:
       return new SecureHashSHA256();
     default:
       NOTIMPLEMENTED();
       return NULL;
   }
 }
 
 }  // namespace crypto