libchrome: Several upstreamable fixes from libchrome

base/memory/shared_memory_android.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/shared_memory.h"
 
 #include <stddef.h>
 #include <sys/mman.h>
 
 #include "base/logging.h"
@@ skipping 34 matching lines @@
   if (-1 == readonly_mapped_file_) {
     DPLOG(ERROR) << "dup() failed";
     return false;
   }
 
   requested_size_ = options.size;
 
   return true;
 }
 
-bool SharedMemory::Delete(const std::string& name) {
+bool SharedMemory::Delete(const std::string& /* name */) {

[danakj, 2016/05/23 02:59:54]

delete

[Luis Héctor Chávez, 2016/05/24 15:27:53]

Done.

   // Like on Windows, this is intentionally returning true as ashmem will
   // automatically releases the resource when all FDs on it are closed.
   return true;
 }
 
-bool SharedMemory::Open(const std::string& name, bool read_only) {
+bool SharedMemory::Open(const std::string& /* name */, bool /* read_only */) {

[danakj, 2016/05/23 02:59:54]

the |name| isn't doing much, but bool isnt clear without a name..

which brings me to why are we doing this? why can't you build chrome with the
same warnings we build chrome with?

I am not excited about trying to maintain unused variable warnings for code that
we don't care t enable that warning on. it's going to bitrot always and we'll
have to deal with followup fixes all the time.

[Luis Héctor Chávez, 2016/05/24 15:27:53]

The problem is that some of these changes are in headers that are included in
other projects, so -Wno-unused-parameter would need to be added in a lot of
places.

I'll raise this with the maintainers of libchrome in both AOSP and Chrome OS :(

   // ashmem doesn't support name mapping
   NOTIMPLEMENTED();
   return false;
 }
 
 }  // namespace base