libchrome: Several upstreamable fixes from libchrome

base/command_line.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 
 #include <algorithm>
 #include <ostream>
 
 #include "base/files/file_path.h"
@@ skipping 131 matching lines @@
     }
   }
   out.push_back('"');
 
   return out;
 }
 #endif
 
 }  // namespace
 
-CommandLine::CommandLine(NoProgram no_program)
+CommandLine::CommandLine(NoProgram /* no_program */)

[danakj, 2016/05/23 02:59:54]

Just remove the name

https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_D...

"Parameter names may be omitted only if the parameter is unused and its purpose
is obvious."

The type name here makes it obvious

[Luis Héctor Chávez, 2016/05/24 15:27:52]

Done.

     : argv_(1),
       begin_args_(1) {
 }
 
 CommandLine::CommandLine(const FilePath& program)
     : argv_(1),
       begin_args_(1) {
   SetProgram(program);
 }
 
@@ skipping 274 matching lines @@
   StringType params(GetArgumentsStringInternal(quote_placeholders));
   if (!params.empty()) {
     string.append(StringType(FILE_PATH_LITERAL(" ")));
     string.append(params);
   }
   return string;
 }
 
 CommandLine::StringType CommandLine::GetArgumentsStringInternal(
     bool quote_placeholders) const {
+#if !defined(OS_WIN)
+  // Avoid an unused warning.
+  (void)quote_placeholders;
+#endif
   StringType params;
   // Append switches and arguments.
   bool parse_switches = true;
   for (size_t i = 1; i < argv_.size(); ++i) {
     StringType arg = argv_[i];
     StringType switch_string;
     StringType switch_value;
     parse_switches &= arg != kSwitchTerminator;
     if (i > 1)
       params.append(StringType(FILE_PATH_LITERAL(" ")));
@@ skipping 16 matching lines @@
   return params;
 }
 
 void CommandLine::ResetStringPieces() {
   switches_by_stringpiece_.clear();
   for (const auto& entry : switches_)
     switches_by_stringpiece_[entry.first] = &(entry.second);
 }
 
 }  // namespace base