Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: runtime/vm/raw_object_snapshot.cc

Issue 1997143002: Don't write Code::code_source_map_ in snapshots. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/raw_object.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object_snapshot.cc
diff --git a/runtime/vm/raw_object_snapshot.cc b/runtime/vm/raw_object_snapshot.cc
index 5f5a15c47f0a52a71b3c84bf2a0ba2acf36439a3..1543db611ec8602775397f8ed946bd2f79b014ce 100644
--- a/runtime/vm/raw_object_snapshot.cc
+++ b/runtime/vm/raw_object_snapshot.cc
@@ -1443,11 +1443,6 @@ RawCode* Code::ReadFrom(SnapshotReader* reader,
(*reader->PassiveObjectHandle()) ^= reader->ReadObjectImpl(kAsReference);
result.StorePointer(reinterpret_cast<RawObject*const*>(
- &result.raw_ptr()->code_source_map_),
- reader->PassiveObjectHandle()->raw());
-
- (*reader->PassiveObjectHandle()) ^= reader->ReadObjectImpl(kAsReference);
- result.StorePointer(reinterpret_cast<RawObject*const*>(
&result.raw_ptr()->stackmaps_),
reader->PassiveObjectHandle()->raw());
@@ -1459,6 +1454,8 @@ RawCode* Code::ReadFrom(SnapshotReader* reader,
LocalVarDescriptors::null());
result.StorePointer(&result.raw_ptr()->inlined_metadata_,
Array::null());
+ result.StorePointer(&result.raw_ptr()->code_source_map_,
+ CodeSourceMap::null());
result.StorePointer(&result.raw_ptr()->comments_,
Array::null());
result.StorePointer(&result.raw_ptr()->return_address_metadata_,
@@ -1520,7 +1517,6 @@ void RawCode::WriteTo(SnapshotWriter* writer,
writer->WriteObjectImpl(ptr()->owner_, kAsReference);
writer->WriteObjectImpl(ptr()->exception_handlers_, kAsReference);
writer->WriteObjectImpl(ptr()->pc_descriptors_, kAsReference);
- writer->WriteObjectImpl(ptr()->code_source_map_, kAsReference);
writer->WriteObjectImpl(ptr()->stackmaps_, kAsReference);
}
« no previous file with comments | « runtime/vm/raw_object.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698