Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1997113002: W3C test importer: Skip importing files whose ref files would be too long. (Closed)

Created:
4 years, 7 months ago by qyearsley
Modified:
4 years, 7 months ago
Reviewers:
tkent, Dirk Pranke
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

W3C test importer: Skip importing files whose ref files would be too long. BUG=609871 Committed: https://crrev.com/2014d9ba913adaeae35027b2bed27a6f38fb278f Cr-Commit-Position: refs/heads/master@{#395202}

Patch Set 1 #

Patch Set 2 : Don't increment number of tests if we skip due to ref test length #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 1 3 chunks +14 lines, -8 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
qyearsley
https://codereview.chromium.org/1997113002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py (right): https://codereview.chromium.org/1997113002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py#newcode252 third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:252: continue The skipping has been moved from import_tests to ...
4 years, 7 months ago (2016-05-20 21:09:47 UTC) #2
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-20 22:13:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997113002/20001
4 years, 7 months ago (2016-05-20 22:19:02 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 23:35:06 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 23:37:17 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2014d9ba913adaeae35027b2bed27a6f38fb278f
Cr-Commit-Position: refs/heads/master@{#395202}

Powered by Google App Engine
This is Rietveld 408576698