Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1997083003: media: Fix gn deps on some media/ targets (Closed)

Created:
4 years, 7 months ago by jrummell
Modified:
4 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Fix gn deps on some media/ targets Add some needed dependencies that have crept in since checking is (not yet) enforced. Also remove an #include that is not needed (and caught by the check). BUG=599578 TEST=gn check //media/mojo/* and //media/base/* are clean Committed: https://crrev.com/a4ecd4eec8a55d39f190209a6edcf1b95571acfa Cr-Commit-Position: refs/heads/master@{#396391}

Patch Set 1 #

Patch Set 2 : changes #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M media/base/ipc/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M media/gpu/BUILD.gn View 1 3 chunks +3 lines, -5 lines 0 comments Download
M media/gpu/rendering_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/vaapi_wrapper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/interfaces/audio_parameters.typemap View 1 chunk +4 lines, -1 line 0 comments Download
M media/mojo/services/BUILD.gn View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_cdm_allocator.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
jrummell
PTAL. Another attempt at fixing gn check issues. Had to add //nogncheck for the 2 ...
4 years, 7 months ago (2016-05-24 22:48:45 UTC) #2
sandersd (OOO until July 31)
lgtm
4 years, 7 months ago (2016-05-24 23:31:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997083003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997083003/20001
4 years, 7 months ago (2016-05-24 23:59:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/234864)
4 years, 7 months ago (2016-05-25 02:48:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997083003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997083003/40001
4 years, 7 months ago (2016-05-27 01:04:55 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-05-27 04:41:52 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 04:44:00 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a4ecd4eec8a55d39f190209a6edcf1b95571acfa
Cr-Commit-Position: refs/heads/master@{#396391}

Powered by Google App Engine
This is Rietveld 408576698