Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1997053002: [Downloads] Split INITIATED_BY_RESUMPTION histogram into automatic and manual. (Closed)

Created:
4 years, 7 months ago by asanka
Modified:
4 years, 7 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Downloads] Split INITIATED_BY_RESUMPTION histogram into automatic and manual. We need to keep track of these separately since manual resumption indicates that users are able to find and use the resumption feature. BUG=7648 Committed: https://crrev.com/9cacc9e6c9ff96c446bafd9aabf1c76178fb625e Cr-Commit-Position: refs/heads/master@{#395654}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M content/browser/download/download_item_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/download/download_item_impl.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M content/browser/download/download_manager_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/download/download_stats.h View 1 chunk +10 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
asanka
PTAL?
4 years, 7 months ago (2016-05-20 18:42:50 UTC) #2
svaldez
lgtm
4 years, 7 months ago (2016-05-20 19:45:05 UTC) #3
asanka
On 2016/05/20 at 19:45:05, svaldez wrote: > lgtm Thanks! asvitkine: I forgot to mention that ...
4 years, 7 months ago (2016-05-21 00:52:52 UTC) #4
Alexei Svitkine (slow)
lgtm
4 years, 7 months ago (2016-05-24 17:26:02 UTC) #5
asanka
Thanks!
4 years, 7 months ago (2016-05-24 17:27:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997053002/1
4 years, 7 months ago (2016-05-24 17:28:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 18:53:01 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 18:55:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9cacc9e6c9ff96c446bafd9aabf1c76178fb625e
Cr-Commit-Position: refs/heads/master@{#395654}

Powered by Google App Engine
This is Rietveld 408576698