Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1997033002: Move continuation getter and setter down to LayoutBlockFlow. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
dmazzoni, wkorman, eae, szager1
CC:
chromium-reviews, eae+blinkwatch, dmazzoni+watch_chromium.org, rwlbuis, aboxhall, aboxhall+watch_chromium.org, szager+layoutwatch_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, je_julie, jchaffraix+rendering, blink-reviews, zoltan1, blink-reviews-layout_chromium.org, sof, yuzo+watch_chromium.org, dmazzoni, haraken, pdr+renderingwatchlist_chromium.org, nektar+watch_chromium.org, leviw+renderwatch, nektarios, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move continuation getter and setter down to LayoutBlockFlow. BUG=302024 Committed: https://crrev.com/8cd74c3fed3dd723fd0be1de2330041151f1f7b0 Cr-Commit-Position: refs/heads/master@{#395681}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -31 lines) Patch
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 4 chunks +13 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
mstensho (USE GERRIT)
@dmazzoni for modules/accesibility/ The rest of the gang for the rest of the stuff. :)
4 years, 7 months ago (2016-05-20 18:32:09 UTC) #2
eae
LGTM
4 years, 7 months ago (2016-05-20 18:37:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997033002/1
4 years, 7 months ago (2016-05-20 18:38:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/187520)
4 years, 7 months ago (2016-05-20 18:45:08 UTC) #7
mstensho (USE GERRIT)
ping @dmazzoni
4 years, 7 months ago (2016-05-23 21:15:24 UTC) #8
dmazzoni
lgtm
4 years, 7 months ago (2016-05-23 23:01:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997033002/20001
4 years, 7 months ago (2016-05-24 18:09:52 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 20:03:12 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 20:04:49 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/8cd74c3fed3dd723fd0be1de2330041151f1f7b0
Cr-Commit-Position: refs/heads/master@{#395681}

Powered by Google App Engine
This is Rietveld 408576698