Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 1997015: Adding Icedtea/OpenJDK to test image. (Closed)

Created:
9 years, 5 months ago by Zhenyao Mo
Modified:
8 years, 5 months ago
Reviewers:
sosa, piman
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, tedbo, rtc, awong, adlr, Chris Masone
Base URL:
ssh://git@chromiumos-git/chromiumos-overlay.git
Visibility:
Public.

Description

Adding Icedtea/OpenJDK to test image.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chromeos-base/chromeos-test/chromeos-test-0.1.0.ebuild View 1 chunk +1 line, -0 lines 1 comment Download
M dev-java/icedtea/icedtea-6.1.7.1.ebuild View 2 chunks +5 lines, -1 line 1 comment Download

Messages

Total messages: 2 (0 generated)
Zhenyao Mo
9 years, 5 months ago (2010-05-11 01:12:44 UTC) #1
sosa
9 years, 5 months ago (2010-05-11 03:32:42 UTC) #2
cpl nits, lgtm otherwise

http://codereview.chromium.org/1997015/diff/1/2
File chromeos-base/chromeos-test/chromeos-test-0.1.0.ebuild (right):

http://codereview.chromium.org/1997015/diff/1/2#newcode45
chromeos-base/chromeos-test/chromeos-test-0.1.0.ebuild:45: dev-java/icedtea
Alphabetical order

http://codereview.chromium.org/1997015/diff/1/3
File dev-java/icedtea/icedtea-6.1.7.1.ebuild (right):

http://codereview.chromium.org/1997015/diff/1/3#newcode100
dev-java/icedtea/icedtea-6.1.7.1.ebuild:100: # build ChromeOS test image.
Chromium OS*

Powered by Google App Engine
This is Rietveld 408576698