Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: tools/viewer/sk_app/android/surface_glue_android.cpp

Issue 1997003003: Save comparisons for release. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/viewer/sk_app/android/surface_glue_android.cpp
diff --git a/tools/viewer/sk_app/android/surface_glue_android.cpp b/tools/viewer/sk_app/android/surface_glue_android.cpp
index 9e35407255f8956eea8d1496692d7684886a4ede..dfe81f53020c012334e9debd064488b563a6d608 100644
--- a/tools/viewer/sk_app/android/surface_glue_android.cpp
+++ b/tools/viewer/sk_app/android/surface_glue_android.cpp
@@ -77,11 +77,13 @@ void SkiaAndroidApp::paintIfNeeded() {
}
void SkiaAndroidApp::postMessage(const Message& message) const {
- SkAssertResult(write(fPipes[1], &message, sizeof(message)) == sizeof(message));
+ SkDEBUGCODE(auto writeSize =) write(fPipes[1], &message, sizeof(message));
+ SkAssertResult(writeSize == sizeof(message));
egdaniel 2016/05/20 19:16:51 here you just want SkASSERT since you don't want a
liyuqian 2016/05/20 19:25:30 Done.
}
void SkiaAndroidApp::readMessage(Message* message) const {
- SkAssertResult(read(fPipes[0], message, sizeof(Message)) == sizeof(Message));
+ SkDEBUGCODE(auto readSize =) read(fPipes[0], message, sizeof(Message));
+ SkAssertResult(readSize == sizeof(Message));
}
void SkiaAndroidApp::inval() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698