Save comparisons for release.

Save comparisons for release.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1997003003

Committed: https://skia.googlesource.com/skia/+/17b4a109219d063dc10a988b1ed46aaefe278477

[liyuqian, 2016-05-20 19:02:48]

Description was changed from

==========
Save comparisons for release.

BUG=skia:
==========

to

==========
Save comparisons for release.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1997003003
==========

[liyuqian, 2016-05-20 19:03:35]

Description was changed from

==========
Save comparisons for release.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1997003003
==========

to

==========
Save comparisons for release.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1997003003
==========

[liyuqian, 2016-05-20 19:03:35]

liyuqian@google.com changed reviewers:
+ egdaniel@google.com

[egdaniel, 2016-05-20 19:16:52]

https://codereview.chromium.org/1997003003/diff/1/tools/viewer/sk_app/android...
File tools/viewer/sk_app/android/surface_glue_android.cpp (right):

https://codereview.chromium.org/1997003003/diff/1/tools/viewer/sk_app/android...
tools/viewer/sk_app/android/surface_glue_android.cpp:81:
SkAssertResult(writeSize == sizeof(message));
here you just want SkASSERT since you don't want any of the code to execute in
release (it will actually crash on build since writeSize is no long declared in
release).

[liyuqian, 2016-05-20 19:25:30]

Thanks

https://codereview.chromium.org/1997003003/diff/1/tools/viewer/sk_app/android...
File tools/viewer/sk_app/android/surface_glue_android.cpp (right):

https://codereview.chromium.org/1997003003/diff/1/tools/viewer/sk_app/android...
tools/viewer/sk_app/android/surface_glue_android.cpp:81:
SkAssertResult(writeSize == sizeof(message));
On 2016/05/20 19:16:51, egdaniel wrote:
> here you just want SkASSERT since you don't want any of the code to execute in
> release (it will actually crash on build since writeSize is no long declared
in
> release).

Done.

[egdaniel, 2016-05-20 19:26:21]

lgtm

[liyuqian, 2016-05-20 19:26:41]

The CQ bit was checked by liyuqian@google.com

[commit-bot: I haz the power, 2016-05-20 19:26:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1997003003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1997003003/20001

[commit-bot: I haz the power, 2016-05-20 19:41:53]

Description was changed from

==========
Save comparisons for release.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1997003003
==========

to

==========
Save comparisons for release.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1997003003

Committed:
https://skia.googlesource.com/skia/+/17b4a109219d063dc10a988b1ed46aaefe278477
==========

[commit-bot: I haz the power, 2016-05-20 19:41:54]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/17b4a109219d063dc10a988b1ed46aaefe278477