Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1997003002: [json] fix encoding change for two-byte gap strings. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[json] fix encoding change for two-byte gap strings. R=mstarzinger@chromium.org BUG=chromium:613570 Committed: https://crrev.com/46aeb2aed87aa24bcb86608b719480230e8567fe Cr-Commit-Position: refs/heads/master@{#36433}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/json-stringifier.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-613570.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Yang
4 years, 7 months ago (2016-05-20 16:56:38 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997003002/1
4 years, 7 months ago (2016-05-20 16:57:07 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-20 17:27:20 UTC) #5
Michael Starzinger
LGTM (rubber-stamped).
4 years, 7 months ago (2016-05-23 08:22:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997003002/1
4 years, 7 months ago (2016-05-23 08:39:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 09:16:35 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 09:19:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46aeb2aed87aa24bcb86608b719480230e8567fe
Cr-Commit-Position: refs/heads/master@{#36433}

Powered by Google App Engine
This is Rietveld 408576698