Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Unified Diff: chrome/browser/ui/webui/version_ui.cc

Issue 1996993002: i18n of Copyright line to use locally correct numeric glyphs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add time.h includes, as per review (also merge) Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/settings/about_handler.cc ('k') | chrome/chrome.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/version_ui.cc
diff --git a/chrome/browser/ui/webui/version_ui.cc b/chrome/browser/ui/webui/version_ui.cc
index 66af4c4340174c121152e86da91e4b1a9eb9b7aa..2961ea8e2bf0455e4af98ab128064e753ac46fc5 100644
--- a/chrome/browser/ui/webui/version_ui.cc
+++ b/chrome/browser/ui/webui/version_ui.cc
@@ -5,7 +5,8 @@
#include "chrome/browser/ui/webui/version_ui.h"
#include "base/command_line.h"
-#include "base/strings/string_number_conversions.h"
+#include "base/i18n/message_formatter.h"
+#include "base/time/time.h"
#include "build/build_config.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/webui/version_handler.h"
@@ -79,12 +80,11 @@ WebUIDataSource* CreateVersionUIDataSource() {
html_source->AddLocalizedString(version_ui::kCompany,
IDS_ABOUT_VERSION_COMPANY_NAME);
- base::Time::Exploded exploded_time;
- base::Time::Now().LocalExplode(&exploded_time);
html_source->AddString(
version_ui::kCopyright,
- l10n_util::GetStringFUTF16(IDS_ABOUT_VERSION_COPYRIGHT,
- base::IntToString16(exploded_time.year)));
+ base::i18n::MessageFormatter::FormatWithNumberedArgs(
+ l10n_util::GetStringUTF16(IDS_ABOUT_VERSION_COPYRIGHT),
+ base::Time::Now()));
html_source->AddLocalizedString(version_ui::kRevision,
IDS_VERSION_UI_REVISION);
html_source->AddString(version_ui::kCL, version_info::GetLastChange());
« no previous file with comments | « chrome/browser/ui/webui/settings/about_handler.cc ('k') | chrome/chrome.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698