i18n of Copyright line to use locally correct numeric glyphs

chrome/tools/mac_helpers/infoplist_strings_util.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Helper tool that is built and run during a build to pull strings from
 // the GRD files and generate the InfoPlist.strings files needed for
 // Mac OS X app bundles.
 
 #import <Foundation/Foundation.h>
 #include <stdint.h>
 #include <stdio.h>
 #include <unistd.h>
 
 #include <memory>
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
+#include "base/i18n/message_formatter.h"
 #include "base/mac/scoped_nsautorelease_pool.h"
-#include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_util.h"
 #include "base/strings/string_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/grit/chromium_strings.h"
 #include "ui/base/resource/data_pack.h"
 
 namespace {
 
 NSString* ApplicationVersionString(const char* version_file_path) {
@@ skipping 220 matching lines @@
                                  short_name_id, short_name_id_str);
     NSString* copyright_format =
         LoadStringFromDataPack(branded_data_pack.get(), cur_lang,
                                IDS_ABOUT_VERSION_COPYRIGHT,
                                "IDS_ABOUT_VERSION_COPYRIGHT");
     NSString* address_book_prompt_description =
         LoadStringFromDataPack(branded_data_pack.get(), cur_lang,
                                IDS_AUTOFILL_ADDRESS_BOOK_PROMPT_DESCRIPTION,
                                "IDS_AUTOFILL_ADDRESS_BOOK_PROMPT_DESCRIPTION");
 
-    base::Time::Exploded exploded_time;
-    base::Time::Now().LocalExplode(&exploded_time);
-    std::vector<base::string16> replacements;
-    replacements.push_back(base::IntToString16(exploded_time.year));
     NSString* copyright = base::SysUTF16ToNSString(
-        base::ReplaceStringPlaceholders(
-            base::SysNSStringToUTF16(copyright_format), replacements, NULL));
+        base::i18n::MessageFormatter::FormatWithNumberedArgs(
+            copyright_format, base::Time::Now()));

[jungshik at Google, 2016/05/25 09:09:36]

This should be |base::SysNSStringToUTF16(copyright_format)|.

[Greg Levin, 2016/05/26 15:25:58]

Done.

 
     // For now, assume this is ok for all languages. If we need to, this could
     // be moved into generated_resources.grd and fetched.
     NSString *get_info = [NSString stringWithFormat:@"%@ %@, %@",
                           name, version_string, copyright];
 
     // Generate the InfoPlist.strings file contents
     NSString* strings_file_contents_string =
         [NSString stringWithFormat:
           @"CFBundleDisplayName = \"%@\";\n"
@@ skipping 49 matching lines @@
         [output_path stringByAppendingPathComponent:@"InfoPlist.strings"];
     if (![strings_file_contents_utf8 writeToFile:output_path
                                       atomically:YES]) {
       fprintf(stderr, "ERROR: Failed to write out '%s'\n",
               [output_path UTF8String]);
       exit(1);
     }
   }
   return 0;
 }