Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1996963002: Revert of [keys] Don't omit write barrier after std::sort (Closed)

Created:
4 years, 7 months ago by Jakob Kummerow
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [keys] Don't omit write barrier after std::sort (patchset #2 id:20001 of https://codereview.chromium.org/1991173002/ ) Reason for revert: This array only contains Smis, see its only store site five lines above: array->set(array_size++, Smi::FromInt(i)); If you want to improve something here, use a C++ array instead of a FixedArray. There's no reason to have this short-lived list on the V8 heap. Original issue's description: > [keys] Don't omit write barrier after std::sort > > BUG= > > Committed: https://crrev.com/681ac8979e820d147380b5fdb2aae773e22f1302 > Cr-Commit-Position: refs/heads/master@{#36412} TBR=mlippautz@chromium.org,cbruni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/ee4ce54494a8a55844a40e3b1da9b5c858cf1481 Cr-Commit-Position: refs/heads/master@{#36414}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/objects.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jakob Kummerow
Created Revert of [keys] Don't omit write barrier after std::sort
4 years, 7 months ago (2016-05-20 14:12:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996963002/1
4 years, 7 months ago (2016-05-20 14:12:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 14:12:34 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 14:14:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee4ce54494a8a55844a40e3b1da9b5c858cf1481
Cr-Commit-Position: refs/heads/master@{#36414}

Powered by Google App Engine
This is Rietveld 408576698