DescriptionRevert of [keys] Don't omit write barrier after std::sort (patchset #2 id:20001 of https://codereview.chromium.org/1991173002/ )
Reason for revert:
This array only contains Smis, see its only store site five lines above:
array->set(array_size++, Smi::FromInt(i));
If you want to improve something here, use a C++ array instead of a FixedArray. There's no reason to have this short-lived list on the V8 heap.
Original issue's description:
> [keys] Don't omit write barrier after std::sort
>
> BUG=
>
> Committed: https://crrev.com/681ac8979e820d147380b5fdb2aae773e22f1302
> Cr-Commit-Position: refs/heads/master@{#36412}
TBR=mlippautz@chromium.org,cbruni@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Committed: https://crrev.com/ee4ce54494a8a55844a40e3b1da9b5c858cf1481
Cr-Commit-Position: refs/heads/master@{#36414}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|