Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: src/compiler.cc

Issue 1996943002: [esnext] Fix various callsites to use is_resumable, not is_generator (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/debug/debug.cc » ('j') | src/debug/debug.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index d99f8d181b2e53d3407d0eb75ec005777718e749..5e611135b1a9c3d7e8e02bfe49e5e7054520e342 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -874,10 +874,11 @@ MaybeHandle<Code> GetBaselineCode(Handle<JSFunction> function) {
return MaybeHandle<Code>();
}
- // TODO(4280): For now we do not switch generators to baseline code because
- // there might be suspended activations stored in generator objects on the
- // heap. We could eventually go directly to TurboFan in this case.
- if (function->shared()->is_generator()) {
+ // TODO(4280): For now we do not switch generators or async functions to
+ // baseline code because there might be suspended activations stored in
+ // generator objects on the heap. We could eventually go directly to
+ // TurboFan in this case.
+ if (function->shared()->is_resumable()) {
return MaybeHandle<Code>();
}
@@ -1306,10 +1307,11 @@ bool Compiler::EnsureDeoptimizationSupport(CompilationInfo* info) {
CompilationInfo unoptimized(info->parse_info(), info->closure());
unoptimized.EnableDeoptimizationSupport();
- // TODO(4280): For now we do not switch generators to baseline code because
- // there might be suspended activations stored in generator objects on the
- // heap. We could eventually go directly to TurboFan in this case.
- if (shared->is_generator()) return false;
+ // TODO(4280): For now we do not switch generators or async functions to
+ // baseline code because there might be suspended activations stored in
+ // generator objects on the heap. We could eventually go directly to
+ // TurboFan in this case.
+ if (shared->is_resumable()) return false;
// TODO(4280): For now we disable switching to baseline code in the presence
// of interpreter activations of the given function. The reasons are:
« no previous file with comments | « no previous file | src/debug/debug.cc » ('j') | src/debug/debug.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698