[esnext] Fix various callsites to use is_resumable, not is_generator

src/runtime/runtime-classes.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/runtime/runtime-utils.h"
 
 #include <stdlib.h>
 #include <limits>
 
 #include "src/arguments.h"
@@ skipping 76 matching lines @@
                                        int start_position, int end_position) {
   Handle<Object> prototype_parent;
   Handle<Object> constructor_parent;
 
   if (super_class->IsTheHole()) {
     prototype_parent = isolate->initial_object_prototype();
   } else {
     if (super_class->IsNull()) {
       prototype_parent = isolate->factory()->null_value();
     } else if (super_class->IsConstructor()) {
-      if (super_class->IsJSFunction() &&
-          Handle<JSFunction>::cast(super_class)->shared()->is_generator()) {
-        THROW_NEW_ERROR(
-            isolate,
-            NewTypeError(MessageTemplate::kExtendsValueGenerator, super_class),
-            Object);
-      }
+      DCHECK(!Handle<JSFunction>::cast(super_class)->shared()->is_resumable());

[caitp (gmail), 2016/05/20 13:35:56]

Is this CHECK really needed? if we have this check, why not also a bunch for
arrow functions, methods, getter/setters, etc?

[Dan Ehrenberg, 2016/05/20 14:59:19]

Just because I'm removing old code on the basis of it being unreachable; the
DCHECK makes sure that it wasn't a mistake.

       ASSIGN_RETURN_ON_EXCEPTION(
           isolate, prototype_parent,
           Runtime::GetObjectProperty(isolate, super_class,
                                      isolate->factory()->prototype_string()),
           Object);
       if (!prototype_parent->IsNull() && !prototype_parent->IsJSReceiver()) {
         THROW_NEW_ERROR(
             isolate, NewTypeError(MessageTemplate::kPrototypeParentNotAnObject,
                                   prototype_parent),
             Object);
       }
       constructor_parent = super_class;
     } else {
       THROW_NEW_ERROR(
           isolate,
-          NewTypeError(MessageTemplate::kExtendsValueNotFunction, super_class),
+          NewTypeError(MessageTemplate::kExtendsValueNotConstructor, super_class),

[caitp (gmail), 2016/05/20 13:35:56]

awfully similar to my CL from yesterday :p but it's cool

[Dan Ehrenberg, 2016/05/20 14:59:19]

Oops! I hadn't gotten around to reviewing it yet. Anyway worked out a test fix
in this patch; I don't think we need new tests.

           Object);
     }
   }
 
   Handle<Map> map =
       isolate->factory()->NewMap(JS_OBJECT_TYPE, JSObject::kHeaderSize);
   map->set_is_prototype_map(true);
   Map::SetPrototype(map, prototype_parent);
   map->SetConstructor(*constructor);
   Handle<JSObject> prototype = isolate->factory()->NewJSObjectFromMap(map);
@@ skipping 274 matching lines @@
 
 RUNTIME_FUNCTION(Runtime_GetSuperConstructor) {
   SealHandleScope shs(isolate);
   DCHECK_EQ(1, args.length());
   CONVERT_ARG_CHECKED(JSFunction, active_function, 0);
   return active_function->map()->prototype();
 }
 
 }  // namespace internal
 }  // namespace v8