third_party/WebKit/Source/bindings/templates/union_container.cpp - Issue 1996903002: [Binding] Delete hasInstance() from ArrayBuffer related interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/union_container.cpp

Issue 1996903002: [Binding] Delete hasInstance() from ArrayBuffer related interfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/interface.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/ArrayBufferOrArrayBufferViewOrDictionary.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/union_container.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/union_container.cpp b/third_party/WebKit/Source/bindings/templates/union_container.cpp

index 920d223c1e320bd9f7dc59047cdf5313b882cdd8..cda4010e3cbb023997d36af100cc7056b9d1e40a 100644

--- a/third_party/WebKit/Source/bindings/templates/union_container.cpp

+++ b/third_party/WebKit/Source/bindings/templates/union_container.cpp

@@ -4,7 +4,11 @@

{% from 'utilities.cpp' import v8_value_to_local_cpp_value %}

{% macro assign_and_return_if_hasinstance(member) %}

+{% if member.is_array_buffer_or_view_type %}

+if (v8Value->Is{{member.type_name}}()) {

+{% else %}

if (V8{{member.type_name}}::hasInstance(v8Value, isolate)) {

+{% endif %}

{{member.cpp_local_type}} cppValue = V8{{member.type_name}}::toImpl(v8::Local<v8::Object>::Cast(v8Value));

impl.set{{member.type_name}}(cppValue);

return;