Source/bindings/tests/results/V8TestTypedefs.cpp - Issue 19969004: Update toNativeArray() / toRefPtrNativeArray() do not match Web IDL specification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestTypedefs.cpp

Issue 19969004: Update toNativeArray() / toRefPtrNativeArray() do not match Web IDL specification (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/canvas/script-tests/canvas-lineDash-input-sequence.js ('K') | « Source/bindings/tests/results/V8TestObject.cpp ('k') | Source/bindings/v8/V8Binding.h » ('j') | Source/bindings/v8/V8Binding.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestTypedefs.cpp

diff --git a/Source/bindings/tests/results/V8TestTypedefs.cpp b/Source/bindings/tests/results/V8TestTypedefs.cpp

index 45c2c40654be0c701a5e73fc53fe44f35bd6d6b1..91156204a3df4e3ba4e99ff3fa74c531a4f4e551 100644

--- a/Source/bindings/tests/results/V8TestTypedefs.cpp

+++ b/Source/bindings/tests/results/V8TestTypedefs.cpp

@@ -282,7 +282,7 @@ static void funcMethod(const v8::FunctionCallbackInfo<v8::Value>& args)

return;

}

- V8TRYCATCH_VOID(Vector<int>, x, toNativeArray<int>(args[0]));

+ V8TRYCATCH_VOID(Vector<int>, x, toNativeArray<int>(args[0], args.GetIsolate()));

imp->func(x);

return;

@@ -355,7 +355,7 @@ static void nullableArrayArgMethod(const v8::FunctionCallbackInfo<v8::Value>& ar

return;

}

TestTypedefs* imp = V8TestTypedefs::toNative(args.Holder());

- V8TRYCATCH_VOID(Vector<String>, arrayArg, toNativeArray<String>(args[0]));

+ V8TRYCATCH_VOID(Vector<String>, arrayArg, toNativeArray<String>(args[0], args.GetIsolate()));

imp->nullableArrayArg(arrayArg);

return;

@@ -422,7 +422,7 @@ static void stringArrayFunctionMethod(const v8::FunctionCallbackInfo<v8::Value>&

}

TestTypedefs* imp = V8TestTypedefs::toNative(args.Holder());

ExceptionState es(args.GetIsolate());

- V8TRYCATCH_VOID(Vector<String>, values, toNativeArray<String>(args[0]));

+ V8TRYCATCH_VOID(Vector<String>, values, toNativeArray<String>(args[0], args.GetIsolate()));

Vector<String> result = imp->stringArrayFunction(values, es);

if (es.throwIfNeeded())

return;

@@ -445,7 +445,7 @@ static void stringArrayFunction2Method(const v8::FunctionCallbackInfo<v8::Value>

}

TestTypedefs* imp = V8TestTypedefs::toNative(args.Holder());

ExceptionState es(args.GetIsolate());

- V8TRYCATCH_VOID(Vector<String>, values, toNativeArray<String>(args[0]));

+ V8TRYCATCH_VOID(Vector<String>, values, toNativeArray<String>(args[0], args.GetIsolate()));

Vector<String> result = imp->stringArrayFunction2(values, es);

if (es.throwIfNeeded())

return;