Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 description("Test that setLineDash converts input argument into a Web IDL sequen ce"); | |
| 2 | |
| 3 var canvas = document.createElement('canvas'); | |
| 4 document.body.appendChild(canvas); | |
| 5 canvas.setAttribute('width', '700'); | |
| 6 canvas.setAttribute('height', '700'); | |
| 7 var ctx = canvas.getContext('2d'); | |
| 8 | |
| 9 var arrayValues = [5, 15, 25]; | |
| 10 | |
| 11 function createTestArray(arrayType) { | |
| 12 var array; | |
| 13 if (arrayType == "Object") { | |
| 14 // Test a "sequence" (Object with length property). | |
| 15 array = new Object(); | |
|
arv (Not doing code reviews)
2013/07/24 16:38:13
array = {length: arrayValues.length};
do-not-use
2013/07/25 08:01:26
OK.
| |
| 16 array.length = arrayValues.length; | |
| 17 } else { | |
| 18 eval("array = new " + arrayType + "(" + arrayValues.length + ");"); | |
|
arv (Not doing code reviews)
2013/07/24 16:38:13
No need for eval here
array = new window[arrayTyp
do-not-use
2013/07/25 08:01:26
Ok.
| |
| 19 } | |
| 20 | |
| 21 for (var i = 0; i < arrayValues.length; ++i) | |
| 22 array[i] = arrayValues[i] | |
| 23 return array; | |
| 24 } | |
| 25 | |
| 26 var lineDash; | |
| 27 function checkLineDash(inputArray) { | |
| 28 // Reset line dash. | |
| 29 ctx.setLineDash([]); | |
| 30 // Set line dash and validate that it worked. | |
| 31 ctx.setLineDash(inputArray); | |
| 32 lineDash = ctx.getLineDash(); | |
| 33 for (var i = 0; i < arrayValues.length; ++i) | |
| 34 shouldBe("lineDash[" + i + "]", "" + arrayValues[i]); | |
| 35 } | |
| 36 | |
| 37 var arrayTypes = ["Array", "Int8Array", "Int16Array", "Int32Array", "Uint8Array" , "Uint16Array", "Uint32Array", "Float32Array", "Float64Array", "Object"]; | |
|
haraken
2013/07/24 15:59:30
Shall we also test Uint8ClampedArray?
arv (Not doing code reviews)
2013/07/24 16:38:13
Change this to pass the constructors instead of th
do-not-use
2013/07/25 08:01:26
Good idea.
do-not-use
2013/07/25 08:01:26
OK.
| |
| 38 | |
| 39 for (var i = 0; i < arrayTypes.length; ++i) { | |
| 40 debug("* Test passing a " + arrayTypes[i] + " as input."); | |
|
arv (Not doing code reviews)
2013/07/24 16:38:13
then do arrayType[i].name
do-not-use
2013/07/25 08:01:26
OK.
| |
| 41 checkLineDash(createTestArray(arrayTypes[i])); | |
| 42 } | |
| 43 | |
| OLD | NEW |