Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1996883002: CSS: SelectorFilter is non-copyable (Closed)

Created:
4 years, 7 months ago by Eric Willigers
Modified:
4 years, 7 months ago
Reviewers:
Timothy Loh, rune
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS: SelectorFilter is non-copyable Declare various CSS classes as non-copyable. BUG=613450 R=timloh@chromium.org Committed: https://crrev.com/9197d2dc48d4d24f540ca49295166d083db9c1ab Cr-Commit-Position: refs/heads/master@{#395056}

Patch Set 1 #

Patch Set 2 : additional classes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M third_party/WebKit/Source/core/css/CSSStyleSheet.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueList.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValuePool.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSet.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryList.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/SelectorFilter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/invalidation/StyleSheetInvalidationAnalysis.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserImpl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/MediaQueryParser.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/MatchResult.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Eric Willigers
4 years, 7 months ago (2016-05-20 06:32:52 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996883002/20001
4 years, 7 months ago (2016-05-20 06:37:40 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-20 07:48:55 UTC) #5
rune
lgtm
4 years, 7 months ago (2016-05-20 11:03:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996883002/20001
4 years, 7 months ago (2016-05-20 11:23:02 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 11:26:55 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 11:28:41 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9197d2dc48d4d24f540ca49295166d083db9c1ab
Cr-Commit-Position: refs/heads/master@{#395056}

Powered by Google App Engine
This is Rietveld 408576698