Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1996873002: AXObject is not copyable (Closed)

Created:
4 years, 7 months ago by Eric Willigers
Modified:
4 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, haraken, nektarios, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, blink-reviews, dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AXObject is not copyable Declare AXObject and AXNodeObject as non-copyable. BUG=613450 R=dmazzoni@chromium.org Committed: https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836 Cr-Commit-Position: refs/heads/master@{#395506}

Patch Set 1 #

Patch Set 2 : more accessibility classes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/accessibility/AXARIAGrid.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXARIAGridCell.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXARIAGridRow.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXImageMapLink.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXList.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXListBox.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXListBoxOption.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMediaControls.h View 1 4 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMenuList.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMockObject.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXProgressIndicator.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXRadioInput.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXSVGRoot.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXSlider.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXSpinButton.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTable.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTableCell.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTableColumn.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTableHeaderContainer.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTableRow.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Eric Willigers
4 years, 7 months ago (2016-05-20 06:31:59 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996873002/1
4 years, 7 months ago (2016-05-20 06:37:52 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-20 08:17:45 UTC) #5
dmazzoni
Could you do this for every class in modules/accessibility?
4 years, 7 months ago (2016-05-20 15:34:08 UTC) #6
Eric Willigers
On 2016/05/20 15:34:08, dmazzoni wrote: > Could you do this for every class in modules/accessibility? ...
4 years, 7 months ago (2016-05-21 00:02:15 UTC) #7
dmazzoni
lgtm Great, thanks!
4 years, 7 months ago (2016-05-23 22:58:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996873002/20001
4 years, 7 months ago (2016-05-23 22:59:41 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 01:33:18 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 01:34:58 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836
Cr-Commit-Position: refs/heads/master@{#395506}

Powered by Google App Engine
This is Rietveld 408576698