chrome/browser/metrics/chrome_metrics_service_client.h - Issue 1996843002: Delay PersistentHistogramAllocator creation until it's known to be used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.h

Issue 1996843002: Delay PersistentHistogramAllocator creation until it's known to be used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed PHA enable/disable code that is no longer used Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_browser_field_trials.cc ('k') | chrome/browser/metrics/chrome_metrics_service_client.cc » ('j') | chrome/browser/metrics/chrome_metrics_service_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/chrome_metrics_service_client.h

diff --git a/chrome/browser/metrics/chrome_metrics_service_client.h b/chrome/browser/metrics/chrome_metrics_service_client.h

index 133b49218e052c90037db711d97be5986f02f86b..ce31ed9b04227b44b4f14c114643a6199343ffc6 100644

--- a/chrome/browser/metrics/chrome_metrics_service_client.h

+++ b/chrome/browser/metrics/chrome_metrics_service_client.h

@@ -79,6 +79,9 @@ class ChromeMetricsServiceClient

EnableMetricsDefault GetDefaultOptIn() override;

bool IsUMACellularUploadLogicEnabled() override;

+ // The name used when storing browser metrics.

Alexei Svitkine (slow) 2016/05/20 14:55:24 Used for what? This class is ChromeMetricsServiceC

bcwhite 2016/05/20 16:01:56 Done.

+ static const char kBrowserMetricsName[];

private:

explicit ChromeMetricsServiceClient(

metrics::MetricsStateManager* state_manager);