Delay PersistentHistogramAllocator creation until it's known to be used.

Delay PersistentHistogramAllocator creation until it's known to be used.

Roughly 25 histograms get created before the allocator is
created in the field-trial setup but these are generally
information about initialization activities that are
reported quickly. Nothing is generally lost should the
browser crash without these being persistent.

BUG=612470
TBR=pfeldman
pfeldman: moved code out of browser_main_runner

Committed: https://crrev.com/374d5fe463635dd811d452649b34c6efc578f860
Cr-Commit-Position: refs/heads/master@{#395101}

[bcwhite, 2016-05-20 13:17:57]

bcwhite@chromium.org changed reviewers:
+ asvitkine@chromium.org

[bcwhite, 2016-05-20 13:20:10]

Description was changed from

==========
Delay PersistentHistogramAllocator creation until it's known to be used.

Roughly 25 histograms get created before the allocator is
created in the field-trial setup but these are generally
information about initialization activities that are
reported quickly. Nothing is generally lost should the
browser crash without these being persistent.

BUG=612470
==========

to

==========
Delay PersistentHistogramAllocator creation until it's known to be used.

Roughly 25 histograms get created before the allocator is
created in the field-trial setup but these are generally
information about initialization activities that are
reported quickly. Nothing is generally lost should the
browser crash without these being persistent.

BUG=612470
TBR=pfeldman
pfeldman: moved code out of browser_main_runner
==========

[Alexei Svitkine (slow), 2016-05-20 14:55:24]

lgtm

https://codereview.chromium.org/1996843002/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/chrome_metrics_service_client.cc (right):

https://codereview.chromium.org/1996843002/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/chrome_metrics_service_client.cc:186: // The name of the
metrics allocator for the browser.
Nit: No need for comment here if there's one in the .h file.

https://codereview.chromium.org/1996843002/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/chrome_metrics_service_client.h (right):

https://codereview.chromium.org/1996843002/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/chrome_metrics_service_client.h:82: // The name used when
storing browser metrics.
Used for what? This class is ChromeMetricsServiceClient so please provide
context because it's not obvious this is related to persistent metrics
allocator. Also define what "storing" means here.

[bcwhite, 2016-05-20 16:01:56]

https://codereview.chromium.org/1996843002/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/chrome_metrics_service_client.cc (right):

https://codereview.chromium.org/1996843002/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/chrome_metrics_service_client.cc:186: // The name of the
metrics allocator for the browser.
On 2016/05/20 14:55:24, Alexei Svitkine wrote:
> Nit: No need for comment here if there's one in the .h file.

Done.

https://codereview.chromium.org/1996843002/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/chrome_metrics_service_client.h (right):

https://codereview.chromium.org/1996843002/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/chrome_metrics_service_client.h:82: // The name used when
storing browser metrics.
On 2016/05/20 14:55:24, Alexei Svitkine wrote:
> Used for what? This class is ChromeMetricsServiceClient so please provide
> context because it's not obvious this is related to persistent metrics
> allocator. Also define what "storing" means here.

Done.

[bcwhite, 2016-05-20 16:58:43]

The CQ bit was checked by bcwhite@chromium.org

[bcwhite, 2016-05-20 16:58:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1996843002/#ps40001
(title: "addressed review comments by Alexei")

[commit-bot: I haz the power, 2016-05-20 16:58:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1996843002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1996843002/40001

[commit-bot: I haz the power, 2016-05-20 17:03:33]

Description was changed from

==========
Delay PersistentHistogramAllocator creation until it's known to be used.

Roughly 25 histograms get created before the allocator is
created in the field-trial setup but these are generally
information about initialization activities that are
reported quickly. Nothing is generally lost should the
browser crash without these being persistent.

BUG=612470
TBR=pfeldman
pfeldman: moved code out of browser_main_runner
==========

to

==========
Delay PersistentHistogramAllocator creation until it's known to be used.

Roughly 25 histograms get created before the allocator is
created in the field-trial setup but these are generally
information about initialization activities that are
reported quickly. Nothing is generally lost should the
browser crash without these being persistent.

BUG=612470
TBR=pfeldman
pfeldman: moved code out of browser_main_runner
==========

[commit-bot: I haz the power, 2016-05-20 17:03:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-20 17:05:22]

Description was changed from

==========
Delay PersistentHistogramAllocator creation until it's known to be used.

Roughly 25 histograms get created before the allocator is
created in the field-trial setup but these are generally
information about initialization activities that are
reported quickly. Nothing is generally lost should the
browser crash without these being persistent.

BUG=612470
TBR=pfeldman
pfeldman: moved code out of browser_main_runner
==========

to

==========
Delay PersistentHistogramAllocator creation until it's known to be used.

Roughly 25 histograms get created before the allocator is
created in the field-trial setup but these are generally
information about initialization activities that are
reported quickly. Nothing is generally lost should the
browser crash without these being persistent.

BUG=612470
TBR=pfeldman
pfeldman: moved code out of browser_main_runner

Committed: https://crrev.com/374d5fe463635dd811d452649b34c6efc578f860
Cr-Commit-Position: refs/heads/master@{#395101}
==========

[commit-bot: I haz the power, 2016-05-20 17:05:23]

Patchset 3 (id:??) landed as
https://crrev.com/374d5fe463635dd811d452649b34c6efc578f860
Cr-Commit-Position: refs/heads/master@{#395101}