content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 1996783002: Make cc::SurfaceId unguessable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 1996783002: Make cc::SurfaceId unguessable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Ben's comment Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index 384bc26e6c6ce9b9ad80bd1be324c28b90d3a594..68c95ddbc1bc7e3ac4e9a1daf478710e01842e05 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -1639,7 +1639,7 @@ uint32_t RenderWidgetHostViewMac::SurfaceIdNamespaceAtPoint(

// case we return our current namespace.

if (id.is_null())

return GetSurfaceIdNamespace();

- return cc::SurfaceIdAllocator::NamespaceForId(id);

+ return id.id_namespace();

}

bool RenderWidgetHostViewMac::ShouldRouteEvent(