Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: cc/surfaces/surface_id_allocator.cc

Issue 1996783002: Make cc::SurfaceId unguessable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Ben's comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/surface_id_allocator.h ('k') | cc/surfaces/surface_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_id_allocator.cc
diff --git a/cc/surfaces/surface_id_allocator.cc b/cc/surfaces/surface_id_allocator.cc
index d71467562e1ca21fbae3ac651fe2aaf1f847177d..8b169a5fa7d47ec82450e03487d06e2a996131d4 100644
--- a/cc/surfaces/surface_id_allocator.cc
+++ b/cc/surfaces/surface_id_allocator.cc
@@ -6,6 +6,7 @@
#include <stdint.h>
+#include "base/rand_util.h"
#include "cc/surfaces/surface_manager.h"
namespace cc {
@@ -26,14 +27,10 @@ SurfaceIdAllocator::~SurfaceIdAllocator() {
}
SurfaceId SurfaceIdAllocator::GenerateId() {
- SurfaceId id(static_cast<uint64_t>(id_namespace_) << 32 | next_id_);
+ uint64_t nonce = base::RandUint64();
+ SurfaceId id(id_namespace_, next_id_, nonce);
next_id_++;
return id;
}
-// static
-uint32_t SurfaceIdAllocator::NamespaceForId(SurfaceId id) {
- return id.id >> 32;
-}
-
} // namespace cc
« no previous file with comments | « cc/surfaces/surface_id_allocator.h ('k') | cc/surfaces/surface_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698