components/mus/public/interfaces/surface_id.mojom - Issue 1996783002: Make cc::SurfaceId unguessable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/public/interfaces/surface_id.mojom

Issue 1996783002: Make cc::SurfaceId unguessable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Hopefully fix hash size_t issue Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/mus/public/interfaces/surface_id.mojom

diff --git a/components/mus/public/interfaces/surface_id.mojom b/components/mus/public/interfaces/surface_id.mojom

index 7d6f657fb0fab8306b06e9a3914d3b5b35d08411..7935e22db96a6932c160c2ef58baa813f17e996d 100644

--- a/components/mus/public/interfaces/surface_id.mojom

+++ b/components/mus/public/interfaces/surface_id.mojom

@@ -15,6 +15,7 @@ module mus.mojom;

// owned by the same client. The actual id namespace must be used to pass

// surface ids to other clients for them to reference.

struct SurfaceId {

- uint32 local;

uint32 id_namespace;

+ uint32 local_id;

Ben Goodger (Google) 2016/05/25 15:30:42 you should document this field:

Fady Samuel 2016/05/25 16:13:52 Done.

+ uint64 nonce;

};

« no previous file with comments | « cc/surfaces/surface_unittest.cc ('k') | components/mus/ws/server_window_surface.cc » ('j') | no next file with comments »