components/mus/ws/server_window_surface.cc - Issue 1996783002: Make cc::SurfaceId unguessable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/ws/server_window_surface.cc

Issue 1996783002: Make cc::SurfaceId unguessable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed unit tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/mus/ws/server_window_surface.cc

diff --git a/components/mus/ws/server_window_surface.cc b/components/mus/ws/server_window_surface.cc

index 4ae254a0cff6652ff661708a3d88be86f2bccc49..7403512862cbc492cdb7d45d728f4baf56dcd12b 100644

--- a/components/mus/ws/server_window_surface.cc

+++ b/components/mus/ws/server_window_surface.cc

@@ -110,7 +110,7 @@ bool ServerWindowSurface::ConvertSurfaceDrawQuad(

// Surface ids originate from the client, meaning they are ClientWindowIds

// and can only be resolved by the client that submitted the frame.

const ClientWindowId other_client_window_id(

- input->surface_quad_state->surface.To<cc::SurfaceId>().id);

+ input->surface_quad_state->surface->local_id);

ServerWindow* other_window = window()->delegate()->FindWindowForSurface(

window(), mojom::SurfaceType::DEFAULT, other_client_window_id);

if (!other_window) {